PM- 228 Fix system information leak #1603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vas3a
approved these changes
Jan 16, 2025
| @@ -115,7 +115,7 @@ checkBrowsers(paths.appPath, isInteractive) | |||
| ) | |||
| .catch(err => { | |||
| if (err && err.message) { | |||
| console.error(err.message) | |||
| console.error('An unexpected error occurred while build') | |||
There was a problem hiding this comment.
can you do the same in here? eg. log the error for dev env?
| @@ -112,7 +112,7 @@ checkBrowsers(paths.appPath, isInteractive) | |||
| }) | |||
| .catch(err => { | |||
| if (err && err.message) { | |||
| console.error(err.message) | |||
| console.error('An error occurred while starting the development server') | |||
There was a problem hiding this comment.
can you do the same in here? eg. log the error for dev env?
kkartunov
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://topcoder.atlassian.net/browse/PM-228
What's in the PR?
The issue is with logging errors in production. So, I've removed them in most cases. And in cases where we're logging error as part of try catch block, I've added a condition to log it only for dev environment. Otherwise, we log the basic error message.