Fixed issue #1007 #1031
Fixed issue #1007 #1031
Conversation
There was a problem hiding this comment.
Thanks, @dashu-baba current solution has some issues.
-
If we create a task the review has to be set to internal, and reviewer to the user who created the task. But it's not set during task creating it's only shown on the edit page, but actually it's not set in the challenge data on the server, see demo video https://monosnap.com/file/Wqy420RNkFwnQ3cjzfYRUL8YEe2yDg
- so we have to set review type to the internal and reviwer to the current user during task creation, not during task edition
-
Hide the start date field and set the startdate = to the current date/time when activating
At the moment start data is set during opening edit page, so we would update this date many times when we save the challenge. We have to set this date one time during challenge activation when we click
Launch,ActivateorLaunch Activebutton anywhere:- challenge edit page https://monosnap.com/file/EtxZX8NgZvCacjFbAsmbQsgoY6WKO5
- challenge view page https://monosnap.com/file/QknKZXAHCjIPeUUgSBcy2hIH3Bj5y7
- challenge list page https://monosnap.com/file/AVIiA3ioOTMmn40yiE4RWwm9BEWqMf
|
@dashu-baba I'm checking the PR, meanwhile could you please resolve the merge conflicts with another changes in |
|
Okay.
…On Tue, Jan 12, 2021 at 6:50 PM maxceem ***@***.***> wrote:
@dashu-baba <https://github.com/dashu-baba> I'm checking the PR,
meanwhile could you please resolve the merge conflicts with another changes
in cf-jan-2021 branch.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1031 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKPWTPUNHPORN2BPH2Z5YADSZRAR7ANCNFSM4V3TZNZA>
.
|
There was a problem hiding this comment.
Thanks, @dashu-baba. The PR works good for me.
I could merge it after resolving merge conflicts and removing console.log.
|
Solved the conflict & conflict log issue.
…On Tue, Jan 12, 2021 at 7:13 PM maxceem ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks, @dashu-baba <https://github.com/dashu-baba>. The PR works good
for me.
I could merge it after resolving merge conflicts and removing console.log.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1031 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKPWTPUYF4ZVPJM35KOHV6DSZRDF5ANCNFSM4V3TZNZA>
.
|
|
Thanks, @dashu-baba. All good now, merged PR and accepted the fix. |
Closed task opens again after few minutes of closing it - intermittently disappears and reappears in Challenge list.
Fixed