Skip to content

add Iterative Reviewer for First2Finish and Task type challenges #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 12, 2021

Conversation

kodar007
Copy link

@kodar007 kodar007 commented Jan 9, 2021

No description provided.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kodar007. I've noticed a couple small issues:

  1. After page reloading the selected reviwer is not shown in the field anymore:

    image

  2. If I select the same reviewer again and click Save I would get error:

    image

Note, that we don't have such issues for the challenge type Challenge which uses role Reviewer.

@kodar007
Copy link
Author

@maxceem done, could you please adjust prize to incorporate fix for point 1 above?

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kodar007 prize update to cover the requirement to show the selected reviewer.

Though at the moment it doesn't work for me.

If I create a new task, set internal reviewer, choose user and click Save, I would get an error:

image

And after reloading the user would not be shown as selected.

@kodar007
Copy link
Author

@maxceem just now noticed, working on it

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @kodar007. Works good now.

@maxceem maxceem merged commit 4ca163b into topcoder-platform:cf-jan-2021 Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants