Skip to content

Commit 4ca163b

Browse files
authored
Merge pull request #1029 from kodar007/fix-issue-1008
add Iterative Reviewer for First2Finish and Task type challenges
2 parents cb57a78 + 84b4ed0 commit 4ca163b

File tree

1 file changed

+11
-4
lines changed

1 file changed

+11
-4
lines changed

src/components/ChallengeEditor/index.js

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,9 @@ class ChallengeEditor extends Component {
180180
try {
181181
const copilotResource = this.getResourceFromProps('Copilot')
182182
const copilotFromResources = copilotResource ? copilotResource.memberHandle : ''
183-
const reviewerResource = this.getResourceFromProps('Reviewer')
183+
const reviewerResource =
184+
(challengeDetails.type === 'First2Finish' || challengeDetails.type === 'Task')
185+
? this.getResourceFromProps('Iterative Reviewer') : this.getResourceFromProps('Reviewer')
184186
const reviewerFromResources = reviewerResource ? reviewerResource.memberHandle : ''
185187
setState({ isConfirm: false, isLaunch: false })
186188
const challengeData = this.updateAttachmentlist(challengeDetails, attachments)
@@ -1005,7 +1007,7 @@ class ChallengeEditor extends Component {
10051007
try {
10061008
const challengeId = this.getCurrentChallengeId()
10071009
// state can have updated assigned member (in cases where user changes assignments without refreshing the page)
1008-
const { challenge: { copilot, reviewer }, assignedMemberDetails: assignedMember } = this.state
1010+
const { challenge: { copilot, reviewer, type }, assignedMemberDetails: assignedMember } = this.state
10091011
const oldMemberHandle = _.get(oldAssignedMember, 'handle')
10101012
const assignedMemberHandle = _.get(assignedMember, 'handle')
10111013
// assigned member has been updated
@@ -1015,8 +1017,13 @@ class ChallengeEditor extends Component {
10151017
const action = await updateChallengeDetails(challengeId, challenge)
10161018
const { copilot: previousCopilot, reviewer: previousReviewer } = this.state.draftChallenge.data
10171019
if (copilot !== previousCopilot) await this.updateResource(challengeId, 'Copilot', copilot, previousCopilot)
1018-
if (reviewer !== previousReviewer) await this.updateResource(challengeId, 'Reviewer', reviewer, previousReviewer)
1019-
1020+
if (type === 'First2Finish' || type === 'Task') {
1021+
const iterativeReviewer = this.getResourceFromProps('Iterative Reviewer')
1022+
const previousIterativeReviewer = iterativeReviewer && iterativeReviewer.memberHandle
1023+
if (reviewer !== previousIterativeReviewer) await this.updateResource(challengeId, 'Iterative Reviewer', reviewer, previousIterativeReviewer)
1024+
} else {
1025+
if (reviewer !== previousReviewer) await this.updateResource(challengeId, 'Reviewer', reviewer, previousReviewer)
1026+
}
10201027
const draftChallenge = { data: action.challengeDetails }
10211028
draftChallenge.data.copilot = copilot
10221029
draftChallenge.data.reviewer = reviewer

0 commit comments

Comments
 (0)