Skip to content

refactor: re-enable lint rules and apply fixes #566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2020
Merged

refactor: re-enable lint rules and apply fixes #566

merged 1 commit into from
May 6, 2020

Conversation

maxceem
Copy link
Contributor

@maxceem maxceem commented May 6, 2020 •
edited
Loading

Fix for #538

@maxceem maxceem mentioned this pull request May 6, 2020
Closed
@maxceem maxceem requested a review from vikasrohit May 6, 2020 08:08
vikasrohit
vikasrohit approved these changes May 6, 2020
View reviewed changes
Copy link

@vikasrohit vikasrohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can't review 245 files 😬

@maxceem maxceem merged commit 60399df into develop May 6, 2020
@maxceem
Copy link
Contributor Author

maxceem commented May 6, 2020

LGTM, Can't review 245 files 😬

no worries, 99% changes has been done automatically by npm run lint:fix

@eisbilir eisbilir deleted the feature/lint-fixes branch November 9, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikasrohit vikasrohit vikasrohit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxceem @vikasrohit