Merge pull request #566 from topcoder-platform/feature/lint-fixes

refactor: re-enable lint rules and apply fixes

Author: maxceem

.eslintrc

@@ -10,15 +10,18 @@
   "rules": {
     "import/no-extraneous-dependencies": ["error", {"devDependencies": ["**/*.test.js", "**/*.spec.js", "src/tests/*.js"]}],
     "max-len": ["error", { "ignoreComments": true, "code": 120 }],
+    "valid-jsdoc": ["error", {
+      "requireReturn": true,
+      "requireReturnType": true,
+      "requireParamDescription": true,
+      "requireReturnDescription": true
+    }],
     "require-jsdoc": ["error", {
       "require": {
         "FunctionDeclaration": true,
         "MethodDefinition": true,
         "ClassDeclaration": true
       }
-    }],
-    "indent": 0,
-    "no-multi-spaces": 0,
-    "valid-jsdoc": 0
+    }]
   }
 }

scripts/data/export/index.js

@@ -31,26 +31,26 @@ logger.info('Script will export data to file:', filePath);
 // check if file exists
 if (fs.existsSync(filePath)) {
 // We delay question for overwrite file, because the question overlaps with a warning message from sequelize module
-Promise.delay(1).then(() => {
-  const rl = readline.createInterface({
-    input: process.stdin,
-    output: process.stdout,
+  Promise.delay(1).then(() => {
+    const rl = readline.createInterface({
+      input: process.stdin,
+      output: process.stdout,
+    });
+    // confirm overwritting to file
+    rl.question(
+      'File already exists, Are you sure to overwrite it? [Y] to overwrite: ',
+      (answer) => {
+        rl.close();
+        if (answer.toLowerCase() === 'y') {
+          logger.info('File will be overwritten.');
+          runExportData(filePath, logger);
+        } else {
+          logger.info('Exit without exporting any data');
+          process.exit(0);
+        }
+      },
+    ); // question()
   });
-  // confirm overwritting to file
-  rl.question(
-    'File already exists, Are you sure to overwrite it? [Y] to overwrite: ',
-    (answer) => {
-      rl.close();
-      if (answer.toLowerCase() === 'y') {
-        logger.info('File will be overwritten.');
-        runExportData(filePath, logger);
-      } else {
-        logger.info('Exit without exporting any data');
-        process.exit(0);
-      }
-    },
-  ); // question()
-});
 } else {
   // get base directory of the file
   const baseDir = path.resolve(filePath, '..');

scripts/es-db-compare/index.js

@@ -147,7 +147,7 @@ async function getProductTimelinesFromES() {
   };
   return es.search(searchCriteria)
     .then((docs) => {
-      const rows = lodash.map(docs.hits.hits, single => single._source);     // eslint-disable-line no-underscore-dangle
+      const rows = lodash.map(docs.hits.hits, single => single._source); // eslint-disable-line no-underscore-dangle
       return rows;
     });
 }
@@ -161,7 +161,7 @@ async function getProjectsFromES() {
   const searchCriteria = getESSearchCriteriaForProject();
   const projects = await es.search(searchCriteria)
     .then((docs) => {
-      const rows = lodash.map(docs.hits.hits, single => single._source);     // eslint-disable-line no-underscore-dangle
+      const rows = lodash.map(docs.hits.hits, single => single._source); // eslint-disable-line no-underscore-dangle
       return rows;
     });
   const timelines = await getProductTimelinesFromES();
@@ -188,7 +188,7 @@ async function getMetadataFromES() {
   };
   return es.search(searchCriteria)
     .then((docs) => {
-      const rows = lodash.map(docs.hits.hits, single => single._source);     // eslint-disable-line no-underscore-dangle
+      const rows = lodash.map(docs.hits.hits, single => single._source); // eslint-disable-line no-underscore-dangle
       if (!rows.length) {
         return lodash.reduce(
           Object.keys(scriptConstants.associations.metadata),

src/constants.js

@@ -243,7 +243,7 @@ export const CONNECT_NOTIFICATION_EVENT = {
   MILESTONE_TRANSITION_ACTIVE: 'connect.notification.project.timeline.milestone.transition.active',
   // When milestone is marked as completed
   MILESTONE_TRANSITION_COMPLETED: 'connect.notification.project.timeline.milestone.transition.completed',
-   // When milestone is marked as paused
+  // When milestone is marked as paused
   MILESTONE_TRANSITION_PAUSED: 'connect.notification.project.timeline.milestone.transition.paused',
   // When milestone is waiting for customers's input
   MILESTONE_WAITING_CUSTOMER: 'connect.notification.project.timeline.milestone.waiting.customer',