Upgrade to Node 12 #531
Merged
Upgrade to Node 12 #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not supported by node 12
challenge 30121951 winning submission by akinwale
onConsume is an async method which suppose to wait until all the messages are process and it's fixed in this commit
This reverts commit 5598e81.
|
Nice catch about the random test failure for the phaseProduct. However, I didn't get the changes in Kafka consumer. Is that fix for unit tests only or is it related to one of the issues we are debugging around unordered processing of kafka messages which resulted in wrong invites data in ES? |
|
@maxceem I am doing a squash merge for this PR instead of regular merge to make our life easier in case we have to revert the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade to Node 12 as per #492
memwatchas the package we use is not supported by Node 12, have to reimplement it again as per Add memwatch to track memory leacks #532sleep(not supported by Node 12) and all related unused codeTwo general fixes have been done which could be included directly into
dev:This PR is ready to be merged into
devso we can watch how does it behave in real-world usage (DEV env).