Skip to content

Commit 3cd0dc3

Browse files
authored
Upgrade to Node 12 (#531)
* chore: use node 12 * chore: removed memwatch * chore: removed redundant "sleep" package not supported by node 12 * test: improve error messages * test: improve error messages 2 * fix: unit test challenge 30121951 winning submission by akinwale * chore: added logs for debug * fix: kafka consumer onConsume is an async method which suppose to wait until all the messages are process and it's fixed in this commit * fix: random test fail * Revert "test: improve error messages 2" This reverts commit 5598e81. * chore: removed logs for debug
1 parent a12dfe2 commit 3cd0dc3

File tree

14 files changed

+2138
-1682
lines changed

14 files changed

+2138
-1682
lines changed

.circleci/config.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ deploy_steps: &deploy_steps
3232
./buildenv.sh -e $DEPLOY_ENV -b ${LOGICAL_ENV}-${APPNAME}-deployvar
3333
source buildenvvar
3434
./master_deploy.sh -d ECS -e $DEPLOY_ENV -t latest -s ${LOGICAL_ENV}-global-appvar,${LOGICAL_ENV}-${APPNAME}-appvar -i ${APPNAME}
35-
35+
3636
echo "======= Running Masterscript - deploy projects-api-consumers ==========="
3737
if [ -e ${LOGICAL_ENV}-${APPNAME}-appvar.json ]; then sudo rm -vf ${LOGICAL_ENV}-${APPNAME}-appvar.json; fi
3838
./buildenv.sh -e $DEPLOY_ENV -b ${LOGICAL_ENV}-${APPNAME}-consumers-deployvar
@@ -42,7 +42,7 @@ deploy_steps: &deploy_steps
4242
jobs:
4343
test:
4444
docker:
45-
- image: circleci/node:8.9.4
45+
- image: circleci/node:12.16.1
4646
- image: circleci/postgres:9.6.2-alpine
4747
environment:
4848
- POSTGRES_USER: circle_test

.nvmrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
v8.9.4
1+
12.16.1

0 commit comments

Comments
 (0)