fix lint errors #46
Merged
fix lint errors #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
parthshah
reviewed
Mar 2, 2017
| /** | ||
| * Sync the database models to db tables. | ||
| */ | ||
|
|
||
| import winston from 'winston'; |
There was a problem hiding this comment.
we are using bunyan not winston
| @@ -47,7 +48,8 @@ | |||
| "pg": "^4.5.5", | |||
| "pg-native": "^1.10.0", | |||
| "sequelize": "^3.23.0", | |||
| "tc-core-library-js": "^1.0.8" | |||
| "tc-core-library-js": "^1.0.8", | |||
| "winston": "^2.3.1" | |||
There was a problem hiding this comment.
remove winston dependency
| @@ -8,6 +8,21 @@ | |||
| "mocha": true | |||
| }, | |||
| "rules": { | |||
| "no-param-reassign": 0, | |||
There was a problem hiding this comment.
We want to use the default settings with eslint-config-airbnb base. Please don't modify the lint rules.
| "no-unused-expressions": 0, | ||
| "newline-per-chained-call": 0, | ||
| "no-underscore-dangle": 0, | ||
| "import/no-extraneous-dependencies": ["error", {"devDependencies": true, "optionalDependencies": false, "peerDependencies": false}], |
There was a problem hiding this comment.
I've changed this to
"import/no-extraneous-dependencies": ["error", {"devDependencies": ["**/*.test.js", "**/*.spec.js"]}],
| @@ -23,7 +26,7 @@ const req = http.request(options, (res) => { | |||
|
|
|||
| res.on('end', () => { | |||
| const body = Buffer.concat(chunks); | |||
| console.log(body.toString()); | |||
| winston.info(body.toString()); | |||
There was a problem hiding this comment.
please don't use winston logger
parthshah
added a commit
that referenced
this pull request
Mar 6, 2017
* TOPCODER CONNECT PROJECTS API ENHANCEMENTS WINNING SUBMISSION (#45) * update readme, update node js version * fix #34 * fix #37, keep project history * move project history update to core API's from event handlers * fix #43 * add unit tests * update direct mock service * update swagger.yaml * add sync script * update postman * update readme * update tests * filter members by copilot role, when promoting copilot * fixing lint errors * fix lint errors (#46) * Revert "fix lint errors" (#47) * updating lint config * fix lint errors (#48) * updating eslint and cleaning up package.json * Fixing path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the lint errors are fixed.