fix lint errors (#46)

Author: Ritesh Sangwan

.eslintignore

@@ -0,0 +1,5 @@
+node_modules
+dist
+.ebextensions
+.elasticbeanstalk
+coverage

.eslintrc

@@ -8,6 +8,21 @@
     "mocha": true
   },
   "rules": {
+    "no-param-reassign": 0,
+    "global-require": 0,
+    "func-names": 0,
+    "no-mixed-operators": 0,
+    "consistent-return": 0,
+    "no-unused-expressions": 0,
+    "newline-per-chained-call": 0,
+    "no-underscore-dangle": 0,
+    "import/no-extraneous-dependencies": ["error", {"devDependencies": true, "optionalDependencies": false, "peerDependencies": false}],
+    "max-len": ["error", {
+      "code": 120,
+      "ignoreComments": true,
+      "ignoreTrailingComments": true,
+      "tabWidth": 2
+    }],
     "valid-jsdoc": ["error", {
       "requireReturn": true,
       "requireReturnType": true,

config/sample.local.js

@@ -1,34 +1,34 @@
 // force using test.json for unit tests
 
-var config
+let config;
 if (process.env.NODE_ENV === 'test') {
-  config = require('./test.json')
+  config = require('./test.json');
 } else {
   config = {
-      "authSecret": "secret",
-      "logLevel": "debug",
-      "captureLogs": "false",
-      "logentriesToken": "",
-      "rabbitmqURL": "amqp://dockerhost:5672",
-      "fileServiceEndpoint": "https://api.topcoder-dev.com/v3/files/",
-      "topicServiceEndpoint": "https://api.topcoder-dev.com/v4/topics/",
-      "directProjectServiceEndpoint": "https://api.topcoder-dev.com/v3/direct",
-      "userServiceUrl": "https://api.topcoder-dev.com/v3/users",
-      "connectProjectsUrl": "https://connect.topcoder-dev.com/projects/",
-      "salesforceLead" : {
-        "webToLeadUrl": 'https://www.salesforce.com/servlet/servlet.WebToLead?encoding=UTF-8',
-        "orgId": "00D2C0000000dO6",
-        "projectNameFieldId": "title",
-        "projectDescFieldId": "description",
-        "projectLinkFieldId": "URL",
-        "projectIdFieldId"  : "00N2C000000Vxxx"
-      },
-      "dbConfig": {
-          "masterUrl": "postgres://coder:mysecretpassword@dockerhost:5432/projectsdb",
-          "maxPoolSize": 50,
-          "minPoolSize": 4,
-          "idleTimeout": 1000
-      }
-  }
+    authSecret: 'secret',
+    logLevel: 'debug',
+    captureLogs: 'false',
+    logentriesToken: '',
+    rabbitmqURL: 'amqp://dockerhost:5672',
+    fileServiceEndpoint: 'https://api.topcoder-dev.com/v3/files/',
+    topicServiceEndpoint: 'https://api.topcoder-dev.com/v4/topics/',
+    directProjectServiceEndpoint: 'https://api.topcoder-dev.com/v3/direct',
+    userServiceUrl: 'https://api.topcoder-dev.com/v3/users',
+    connectProjectsUrl: 'https://connect.topcoder-dev.com/projects/',
+    salesforceLead: {
+      webToLeadUrl: 'https://www.salesforce.com/servlet/servlet.WebToLead?encoding=UTF-8',
+      orgId: '00D2C0000000dO6',
+      projectNameFieldId: 'title',
+      projectDescFieldId: 'description',
+      projectLinkFieldId: 'URL',
+      projectIdFieldId: '00N2C000000Vxxx',
+    },
+    dbConfig: {
+      masterUrl: 'postgres://coder:mysecretpassword@dockerhost:5432/projectsdb',
+      maxPoolSize: 50,
+      minPoolSize: 4,
+      idleTimeout: 1000,
+    },
+  };
 }
-module.exports = config
+module.exports = config;

migrations/sync.js

@@ -1,20 +1,20 @@
-'use strict'
-
 /**
  * Sync the database models to db tables.
  */
 
+import winston from 'winston';
+
 /**
  * Make sure we are in development mode
  * @type {String}
  */
 // process.env.NODE_ENV = 'development'
 
-require('./dist/models').default.sequelize.sync({ force: true })
+require('../dist/models').default.sequelize.sync({ force: true })
   .then(() => {
-    console.log('Database synced successfully')
-    process.exit()
+    winston.info('Database synced successfully');
+    process.exit();
   }).catch((err) => {
-    console.error('Error syncing database', err)
-    process.exit(1)
-  })
+    winston.error('Error syncing database', err);
+    process.exit(1);
+  });

newrelic.js

@@ -1,18 +1,18 @@
-'use strict'
+
 
 /**
  * New Relic agent configuration.
  *
  * See lib/config.defaults.js in the agent distribution for a more complete
  * description of configuration variables and their potential values.
  */
-var appName = "tc-projects-service"
+let appName = 'tc-projects-service';
 if (process.env.NODE_ENV === 'development') {
-  appName += "-dev"
+  appName += '-dev';
 } else if (process.env.NODE_ENV === 'qa') {
-  appName += "-qa"
+  appName += '-qa';
 } else {
-  appName += '-prod'
+  appName += '-prod';
 }
 
 exports.config = {
@@ -30,6 +30,6 @@ exports.config = {
      * issues with the agent, 'info' and higher will impose the least overhead on
      * production applications.
      */
-    level: 'info'
-  }
-}
+    level: 'info',
+  },
+};

package.json

@@ -9,7 +9,8 @@
   "scripts": {
     "build": "babel src -d dist --presets es2015",
     "sync": "node migrations/sync.js",
-    "lint": "./node_modules/.bin/eslint src",
+    "lint": "./node_modules/.bin/eslint .",
+    "lint:fix": "./node_modules/.bin/eslint . --fix || true",
     "prestart": "npm run -s build",
     "start": "node dist",
     "start:dev": "NODE_ENV=local PORT=8001 nodemon -w src --exec \"babel-node src --presets es2015\" | ./node_modules/.bin/bunyan",
@@ -47,7 +48,8 @@
     "pg": "^4.5.5",
     "pg-native": "^1.10.0",
     "sequelize": "^3.23.0",
-    "tc-core-library-js": "^1.0.8"
+    "tc-core-library-js": "^1.0.8",
+    "winston": "^2.3.1"
   },
   "devDependencies": {
     "babel-cli": "^6.9.0",

src/events/projects/index.js

@@ -1,6 +1,4 @@
-import config from 'config';
-import querystring from 'querystring';
-import util from '../../util';
+
 
 /**
  * Creates a lead in salesforce for the connect project.

src/index.js

@@ -1,7 +1,5 @@
 
 
-import models from './models';
-
 // include newrelic
 if (process.env.NODE_ENV !== 'test' && process.env.NODE_ENV !== 'local') {
   require('newrelic');
@@ -11,6 +9,7 @@ const app = require('./app');
 
 /**
  * Handle server shutdown gracefully
+ * @return {Void}         This function returns void
  */
 function gracefulShutdown() {
   app.services.pubsub.disconnect()

src/middlewares/checkRole.js

@@ -7,11 +7,12 @@
  * @version 1.0
  */
 import config from 'config';
+
 const util = require('tc-core-library-js').util(config);
 
 module.exports = function (roleName) {
   return function (req, res, next) {
-    if (!req.authUser || !Array.isArray(req.authUser.roles) || req.authUser.roles.indexOf(roleName) == -1) {
+    if (!req.authUser || !Array.isArray(req.authUser.roles) || req.authUser.roles.indexOf(roleName) === -1) {
       return res.status(403)
           .json(util.wrapErrorResponse(req.id, 403, 'You are not allowed to perform this action.'));
     }

src/mocks/addBillingAccount.js

@@ -1,3 +1,6 @@
+/* eslint-disable max-len */
+import winston from 'winston';
+
 const http = require('https');
 
 const options = {
@@ -23,7 +26,7 @@ const req = http.request(options, (res) => {
 
   res.on('end', () => {
     const body = Buffer.concat(chunks);
-    console.log(body.toString());
+    winston.info(body.toString());
   });
 });
 req.write('{\n "billingAccountId": 123456789\n}');

src/mocks/addCopilot.js

@@ -1,3 +1,6 @@
+/* eslint-disable max-len */
+import winston from 'winston';
+
 const http = require('https');
 
 const options = {
@@ -23,7 +26,7 @@ const req = http.request(options, (res) => {
 
   res.on('end', () => {
     const body = Buffer.concat(chunks);
-    console.log(body.toString());
+    winston.info(body.toString());
   });
 });
 req.write('{\n "copilotUserId": 123456789\n}');

src/mocks/createProject.js

@@ -1,3 +1,6 @@
+/* eslint-disable max-len */
+import winston from 'winston';
+
 const http = require('https');
 
 const options = {
@@ -23,7 +26,7 @@ const req = http.request(options, (res) => {
 
   res.on('end', () => {
     const body = Buffer.concat(chunks);
-    console.log(body.toString());
+    winston.info(body.toString());
   });
 });
 

src/mocks/direct.js

@@ -1,17 +1,20 @@
 
 
-import express from 'express';
+import express, { Router } from 'express';
 import _ from 'lodash';
 import bodyParser from 'body-parser';
 import config from 'config';
 import coreLib from 'tc-core-library-js';
 import expressRequestId from 'express-request-id';
-import Router from 'express';
 import https from 'https';
 import path from 'path';
 import fs from 'fs';
-config.version = 'v3';
+
 const util = require('tc-core-library-js').util(config);
+const jwtAuth = require('tc-core-library-js').middleware.jwtAuthenticator;
+
+config.version = 'v3';
+
 const app = express();
 app.use(bodyParser.urlencoded({
   extended: false,
@@ -33,10 +36,9 @@ app.use(coreLib.middleware.logger(null, logger));
 app.logger = logger;
 
 const router = Router();
-const jwtAuth = require('tc-core-library-js').middleware.jwtAuthenticator;
 router.all('/v3/direct/projects*', jwtAuth());
 
-let projectId = 2;
+const projectId = 2;
 const projects = {
   1: {
     projectName: 'test direct project1',
@@ -55,55 +57,56 @@ router.route('/v3/direct/projects')
     })
     .post((req, res) => {
       app.logger.info({ body: req.body }, 'create direct project');
-      const newId = projectId++;
+      const newId = projectId + 1;
       req.body.id = newId;
       projects[newId] = req.body;
       res.json(util.wrapResponse(req.id, { projectId: newId }));
     });
 
 router.route('/v3/direct/projects/:projectId(\\d+)/billingaccount')
     .post((req, res) => {
-      const projectId = req.params.projectId;
-      app.logger.info({ body: req.body, projectId }, 'add billingaccount to Project');
-      if (projects[projectId]) {
-        projects[projectId] = _.merge(projects[projectId], req.body);
-        res.json(util.wrapResponse(req.id, { billingAccountName: `mock account name for ${req.body.billingAccountId}` }));
+      const pId = req.params.projectId;
+      app.logger.info({ body: req.body, pId }, 'add billingaccount to Project');
+      if (projects[pId]) {
+        projects[pId] = _.merge(projects[pId], req.body);
+        res.json(util.wrapResponse(req.id, { billingAccountName: 'mock account name for ' +
+          `${req.body.billingAccountId}` }));
       } else {
-        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${projectId}`));
+        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${pId}`));
       }
     });
 
 
 router.route('/v3/direct/projects/:projectId(\\d+)/copilot')
     .post((req, res) => {
-      const projectId = req.params.projectId;
-      app.logger.info({ body: req.body, projectId }, 'add copilot to Project');
-      if (projects[projectId]) {
-        projects[projectId] = _.merge(projects[projectId], req.body);
-        res.json(util.wrapResponse(req.id, { copilotProjectId: projectId }));
+      const pId = req.params.projectId;
+      app.logger.info({ body: req.body, pId }, 'add copilot to Project');
+      if (projects[pId]) {
+        projects[pId] = _.merge(projects[pId], req.body);
+        res.json(util.wrapResponse(req.id, { copilotProjectId: pId }));
       } else {
-        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${projectId}`));
+        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${pId}`));
       }
     })
     .delete((req, res) => {
-      const projectId = req.params.projectId;
-      app.logger.info({ body: req.body, projectId }, 'remove copilot from Project');
-      if (projects[projectId]) {
-        projects[projectId] = _.omit(projects[projectId], 'copilotUserId');
+      const pId = req.params.projectId;
+      app.logger.info({ body: req.body, pId }, 'remove copilot from Project');
+      if (projects[pId]) {
+        projects[pId] = _.omit(projects[pId], 'copilotUserId');
         res.json(util.wrapResponse(req.id, true));
       } else {
-        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${projectId}`));
+        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${pId}`));
       }
     });
 
 router.route('/v3/direct/projects/:projectId(\\d+)/permissions')
     .post((req, res) => {
-      const projectId = req.params.projectId;
-      app.logger.info({ body: req.body, projectId }, 'add permissions to Project');
-      if (projects[projectId]) {
+      const pId = req.params.projectId;
+      app.logger.info({ body: req.body, pId }, 'add permissions to Project');
+      if (projects[pId]) {
         res.json();
       } else {
-        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${projectId}`));
+        res.json(util.wrapErrorResponse(req.id, 404, `Cannot find direct project ${pId}`));
       }
     });