Skip to content

Add new tests for project update #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

r0hit-gupta
Copy link
Contributor

Fixes #314

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r0hit-gupta

I've added several comments to the code, please, have a look.

@r0hit-gupta
Copy link
Contributor Author

Fixed. Please review.

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @r0hit-gupta.

@maxceem maxceem merged commit 2620db4 into topcoder-platform:dev Jul 9, 2019
@vikasrohit
Copy link

@maxceem I noticed that the PR was against dev, was it intentional?

@maxceem
Copy link
Contributor

maxceem commented Jul 9, 2019

Oh no, @vikasrohit reverted #338

Will merge to cf18 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[$35] Prevent non admins to update the template id of a project
3 participants