[$35] Prevent non admins to update the template id of a project

[vikasrohit]

As of now a customer can update the template id of their projects by directly calling the API endpoint. Although, it does not do any harm but it can result in issues in rendering a project because data for the project would not be stored in the formatted as per the updated templated id.
So, we should prevent updating template id of an existing project for non admin users.

fyi @maxceem @RishiRajSahu

[maxceem]

We should update the existent unit test after this fix. And also, we should create 2 new unit tests to check that:

• admin user can update templateId
• non-admin user cannot update templateId and got error 403 - You don't have permission to change project template.

[gets0ul]

Is this different with connect-app bug bash?
Can I work on this?

[maxceem]

It's the same Bug Bash with Connect app. You can work no this, but you can work only at one issue at a time. So you should complete appirio-tech/connect-app#3112 first, or unassign that one first.

[r0hit-gupta]

I would like to work on this.

[maxceem]

@r0hit-gupta assigned.

[r0hit-gupta]

@maxceem its already ignoring the template Id. https://github.com/topcoder-platform/tc-project-service/blob/dev/src/routes/projects/update.js#L65

[maxceem]

Thanks, @r0hit-gupta. Please, hold on this until I confirm if we should let admins to update it.

@vikasrohit currently, we cannot update templateId should we let admins to do it?

[maxceem]

@r0hit-gupta as we are on hold for this one, you may pick up another one, if you want to #323