Skip to content

Feature/email settings #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 21, 2018
Merged

Feature/email settings #48

merged 11 commits into from
May 21, 2018

Conversation

gondzo
Copy link
Collaborator

@gondzo gondzo commented May 20, 2018

@vikasrohit Before deploying this one, you need to manually execute this script on the notifications database https://github.com/maxceem/tc-notifications/blob/5e1700ec7e294f22517e89445db2137485dd02ca/migrations/v2.0.sql

then just merge this PR and the one in connect-app repo. There are no new environment variables

appirio-tech/connect-app#2007

@vikasrohit
Copy link

Oky @gondzo. I didn't understood the usage of the name field, it is intialized with enabled which does seems to justify the field name.
Also, do we need to run any script to update existing data for rename of column deliveryMethod? or is it okay to keep existing values for this column?

@gondzo
Copy link
Collaborator Author

gondzo commented May 21, 2018

deliveryMethod values should be same as before (web/email)

name field is added for supporting generic value types in the future. Right now we only have a toggle (on/off) that is named enabled. If we later decide to add a new setting (targetEmail for example), we would still be able to use the same table structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants