Email bundle and refactoring

[maxceem]

Issues: #37 #38 #40 and appirio-tech/connect-app#1991

Note:

• To test notifications API locally, you can use this fork of tc-core-library-js which skips token validation:

  npm i https://github.com/maxceem/tc-core-library-js/tree/skip-validation
  

  It's a merged https://github.com/gondzo/tc-core-library-js with https://github.com/appirio-tech/tc-core-library-js/tree/feature/m2mtoken

[gondzo]

Looks good.
@vikasrohit - we need to make some changes to the email service too as it won't support loops in the email template, see this comment #40 (comment)

Before deploying this one, you need to manually execute this script on the notifications database https://github.com/maxceem/tc-notifications/blob/5e1700ec7e294f22517e89445db2137485dd02ca/migrations/v2.0.sql

then just merge this PR and the one in connect-app repo. There are no new environment variables

[vikasrohit]

@gondzo I think we have to build the HTML in tc-notifications instead of letting email service doing this for us because email service should not know how to unroll the list of objects into HTML. As suggested in the post, we can created a variable in template e.g. {{notificationsHTML}} and send the prepared HTML for this variable in our bundled event payload along with the list of notifications. For now we won't use the actual notifications in templates, but once we get support from Sendgrid, we can prepare a template with looping. They have it in beta so may be can try it out, in parallel, with a different version of the same email template.

[gondzo]

OK, then you can create a new template in sendgrid with notificationsHTML parameter and I'll add the change to prepare the html in notifications service.

[vikasrohit]

@gondzo I have created a new template in Sendgrid for the event type 'notifications.action.email.connect.project.bundled' which just contain {{notificationsHTML}} as variable to replace. It is deployed in dev and you should be able to send emails now with this event. Let me know if you see any errors.

[gondzo]

@vikasrohit I have added the changes to prepare html for bundled events, but pushing the event to bus api returns an error Check your token scope.. Any ideas which scope do we need to call bus-api service? And in general, do we have a mapping of required scopes for various services?

[vikasrohit]

@gondzo I think there are some changes going on for machine to machine tokens for new auth upgrade. I guess, we need to merge our changes into dev to get those changes reflected on our changes. I am merging the PR after invoking the migration sql on dev instance. Lets hope it works after that.