Skip to content

add title field to Job model #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 7, 2021

Conversation

imcaizheng
Copy link
Contributor

  • update ES mapping for the Job index
  • update Joi schema

- update ES mapping for the Job index
- update Joi schema
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@imcaizheng tested locally and works good.

@maxceem maxceem merged commit 2dbd775 into topcoder-platform:dev Jan 7, 2021
@imcaizheng
Copy link
Contributor Author

@maxceem Just in case, we may need to update existing ES server deployed for DEV similar with topcoder-platform/taas-apis#22 (comment)

@maxceem
Copy link
Contributor

maxceem commented Jan 7, 2021

Thanks for pointing this out @imcaizheng. As per discussion in that ticket it looks like AWS ES doesn't support such commands, so for existent data, we would not have title for now. I think we have to create a script that would reindex all the data from DB to ES to handle such situations in the future.

@maxceem
Copy link
Contributor

maxceem commented Jan 7, 2021

@imcaizheng but we still have to updated mapping, right?

@imcaizheng
Copy link
Contributor Author

@maxceem Yes. It was confirmed by nkumar-topcoder that update mapping would work for AWS ES in this comment topcoder-platform/taas-apis#22 (comment).

It seems like a workaround for migrating data from DB to ES every time indices are modified, but it is quite a solution for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants