add input checks of jobId and userId to JobCandidate and ResouceBooking services #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxceem
approved these changes
Dec 15, 2020
There was a problem hiding this comment.
@imcaizheng thanks for taking care of the swagger too.
Works perfectly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
POST(PUT) /jobCandidatesandPOST(PUT) /resourceBookingsto include 404 responses.Verification
Execute the following requests with different jobIds or userIds for validating:
Jobs > create job candidate with booking managerJobs > put job candidate with booking managerJob Candidates > create resource booking with booking managerJob Candidates > put resource booking with booking managerNotes
PATCH /jobCandidatesandPATCH /resourceBookingremain unchanged since these endpoints do not related to jobId or userId.