[$50]`JobCandidate` and `ResourceBooking` job and user consistency validation

[SathyaJayabal]

Create Resource Booking: Validate job candidate object present for given userid and jobid

[maxceem]

Task:

1. When creating a new JobCandidate we have to make sure, that jobId and userId are valid (exists) or return an error.
   • the same check should be when we PUT or PATCH
2. The same when we are creating a ResourceBooking
   • the same check should be when we PUT or PATCH
3. When we creating a ResourceBooking we have to also validate there is existent JobCandidate records with the same jobId and userId or return an error. (no need)

[maxceem]

@imcaizheng ready for pick up if you like.

[maxceem]

Hold on. Have to clarify one more requirement.

When we creating a ResourceBooking we have to also validate there is existent JobCandidate records with the same jobId and userId.

@nkumar-topcoder should we also check the status of JobCandidate? I guess we should not allow creating ResourceBooking for JobCandidate if JobCandidate is already has selected status. What do you think?

[nkumar-topcoder]

Good catch, but only based on selected status for the particular userid, job id and enddate. if candidate is selected, then we have reference to jobid we need to check when his assignment ending. I think this needs discussion

…

On Fri, 4 Dec 2020, 4:55 pm maxceem ***@***.*** wrote: Hold on. Have to clarify one more requirement. When we creating a ResourceBooking we have to also validate there is existent JobCandidate records with the same jobId and userId. @nkumar-topcoder <https://github.com/nkumar-topcoder> should we also check the status of JobCandidate? I guess we should not allow creating ResourceBooking for JobCandidate if JobCandidate is already has selected status. What do you think? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#33 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AIARM25QP4JDKLNZAAEZSEDSTDBJJANCNFSM4ULPYD4A> .

[maxceem]

@nkumar-topcoder I've reviewed the Google Sheet about this task.

Regarding the task 3:

When we creating a ResourceBooking we have to also validate there is existent JobCandidate records with the same jobId and userId or return an error.

It feels like we can drop this requirement. I think we should let creating ResourceBooking even without JobCandidate. This would make our life more easier. Let's say we want create some new UI where we want to be able directly assigned members to the jobs. If we require existent JobCandidate we would need to create it all the time first, just to be able to create ResourceBooking immediately after that.

[maxceem]

@imcaizheng you may pick this up if you like.

[imcaizheng]

PR created #55