Skip to content

fix: issue #507 #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2021
Merged

fix: issue #507 #548

merged 2 commits into from
Sep 16, 2021

Conversation

yoution
Copy link
Contributor

@yoution yoution commented Sep 9, 2021

Deployment Guide

Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yoution.

I've noticed a few more places where we have to update the Job Start Date format.

In TaaS API

There are more places where we use helper.formatDateEDT. I guess we only use it for Job Start Date, so all these places could be updated and the method helper.formatDateEDT completely removed.

image

In Postman

Job search requests:

image

Inside Create Demo Data for Team folder we also have several create Job requests to update:

image

Similar inside Test Permission Rules folder

image

And inside Notifications Demo

image

@yoution yoution requested a review from maxceem September 10, 2021 09:50
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @yoution looks good now

@maxceem maxceem merged commit fb4a89e into topcoder-platform:dev Sep 16, 2021
@yoution yoution deleted the issue-507 branch October 27, 2021 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants