Job start date is one day behind the actual date in TAAS(sometimes)

[sdgun]

Team: https://platform.topcoder-dev.com/taas/myteams/18361/positions/e9a270d1-a18d-403f-af94-b1f93d9f4f63
The job start date in above is 18th August, but in the email it is 17th August

[maxceem]

This is quite a complex issue, need to discuss solution with Atif, Nagendra, Will. We will take care of this during cool down period.

[maxceem]

Sum up:

Update TaaS API

• We already had similar issue for WorkPeriods and ResourceBookings. The solution was to update date format from type: Sequelize.DATE to Sequelize.DATEONLY, so we don't store time and timezone anymore and only store date in format 2021-12-29.
• To solve this issue we have to update the format of the Job startDate from type: Sequelize.DATE to type: Sequelize.DATEONLY,:
  • create a migration script in the migrations folder which would change the column type in the DB (see how we did that for Resource Bookings https://github.com/topcoder-platform/taas-apis/blob/revert-532-feature/revert-splitting-email-templates/migrations/2021-04-22-1-make-resource-booking-dates-store-no-timestamp.js#L0-L1)
  • update all the API endpoints so now they accept date in a new date format (see or example Resource Bookings https://github.com/topcoder-platform/taas-apis/blob/revert-532-feature/revert-splitting-email-templates/src/services/ResourceBookingService.js#L348)
• Make sure, that when we pass Job Start Date to the Notifications Emails, we properly format it like now Aug 17, 2021:
  • see all the places where we use method helper.formatDateEDT
  • NOTE: that we would not longer need to convert it to EDT and we would have to show it as it is after this migration
• Update Swagger
• Make sure all the request work in Postman after this change
• Make sure demo data populate by npm run import (or npm run local:init) works

Update TaaS App

App: https://platform.topcoder-dev.com/taas/myteams
Repo: https://github.com/topcoder-platform/taas-app

• As we updated Job startDate format we also have to update TaaS App:

  • Make sure that in all the places where we display Job Start Date, it still displayed correctly using the same date format which we now use in UI
  • When we create and edit Jobs make sure that new date format is supported (you may check editing Resource Bookings for example where we support new date format)

• Also, when we are creating new teams we also creating jobs using this URL https://platform.topcoder-dev.com/taas/createnewteam. So we also might need to make sure it works with update API and job Start Date format.

Verification

Provide a quick demo video showing TaaS App works locally with updated API:

• create/view/edit jobs with start date inside existent team like this https://platform.topcoder-dev.com/taas/myteams/17993
• create new team using link https://platform.topcoder-dev.com/taas/createnewteam

[yoution]

@maxceem please assign to me

[yoution]

demo video
https://monosnap.com/file/UqQYFUJo0cp8fVw8qnpdsZvSfsJ1KH
https://monosnap.com/file/KdcClfdxVMXKBiGjm1dRWoC5DqeWk6

[maxceem]

DEV PRs:

• TaaS API fix: issue #507 #548
• TaaS ES Processor support Job Start Date format without time taas-es-processor#102
• TaaS App fix issue topcoder-platform/taas-apis#507 topcoder-archive/topcoder-platform-taas-app#501

[maxceem]

QA Guidelines:

The fix for this this issue affects every place where show or edit Job Start Date, so we have to do regression testing for all such places.

TaaS App https://platform.topcoder-dev.com/taas/myteams

• create/view/edit jobs with start date inside existent team like this https://platform.topcoder-dev.com/taas/myteams/17993
• create new team using link https://platform.topcoder-dev.com/taas/createnewteam
• make sure that Zap integration with RCRM works good. For example that jobs created are correctly created/shown in RCRM

Gigs App https://platform.topcoder-dev.com/earn/my-gigs

I think we don't use Job Start Date in this app, but it would be good make sure nothing got broken in general.