Skip to content

PROD-3232 Adds the uni nav snippet -> PROD-3115_uni-nav #421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 21, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src-ts/config/constants.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,5 @@ export enum ToolTitle {
settings = 'Account Settings',
work = 'Work',
}

export const PagePortalId: string = 'page-subheader-portal-el'
7 changes: 5 additions & 2 deletions src-ts/config/environments/environment.default.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ export const EnvironmentConfigDefault: EnvironmentConfigModel = {
V3: 'https://api.topcoder-dev.com/v3',
V5: 'https://api.topcoder-dev.com/v5',
},
AUTH: {
ACCOUNTS_APP_CONNECTOR: 'https://accounts-auth0.topcoder-dev.com',
},
ENV: 'default',
LOGGING: {
PUBLIC_TOKEN: 'puba0825671e469d16f940c5a30dc738f11',
Expand All @@ -38,7 +41,7 @@ export const EnvironmentConfigDefault: EnvironmentConfigModel = {
USER_PROFILE: `${COMMUNITY_WEBSITE}/members`,
WP_CONTENT: `${COMMUNITY_WEBSITE}/wp-content`,
},
URL: {
ACCOUNTS_APP_CONNECTOR: 'https://accounts-auth0.topcoder-dev.com',
UNIVERSAL_NAV: {
URL: 'https://uni-nav.topcoder-dev.com/tc-universal-nav.js',
},
}
7 changes: 5 additions & 2 deletions src-ts/config/environments/environment.prod.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,9 @@ export const EnvironmentConfigProd: EnvironmentConfigModel = {
V3: 'https://api.topcoder.com/v3',
V5: 'https://api.topcoder.com/v5',
},
AUTH: {
ACCOUNTS_APP_CONNECTOR: 'https://accounts-auth0.topcoder.com',
},
DISABLED_TOOLS: [],
ENV: 'prod',
// TODO: Move stripe creds to .env file
Expand All @@ -36,7 +39,7 @@ export const EnvironmentConfigProd: EnvironmentConfigModel = {
USER_PROFILE: `${COMMUNITY_WEBSITE}/members`,
WP_CONTENT: `${COMMUNITY_WEBSITE}/wp-content`,
},
URL: {
ACCOUNTS_APP_CONNECTOR: 'https://accounts-auth0.topcoder.com',
UNIVERSAL_NAV: {
URL: 'https://uni-nav.topcoder.com/tc-universal-nav.js',
},
}
31 changes: 0 additions & 31 deletions src-ts/header/Header.module.scss

This file was deleted.

79 changes: 61 additions & 18 deletions src-ts/header/Header.tsx
Original file line number Diff line number Diff line change
@@ -1,20 +1,63 @@
import { FC } from 'react'

import { Logo } from './logo'
import { ToolSelectors } from './tool-selectors'
import { UtilitySelectors } from './utility-selectors'
import styles from './Header.module.scss'

const Header: FC<{}> = () => (
<div className={styles['header-wrap']}>
<header className={styles.header}>
<ToolSelectors isWide={false} />
<Logo />
<ToolSelectors isWide />
<UtilitySelectors />
</header>
<div id='page-subheader-portal-el' className={styles.subheader} />
</div>
)
import { Dispatch, FC, MutableRefObject, SetStateAction, useContext, useEffect, useRef, useState } from 'react'
import classNames from 'classnames'

import { EnvironmentConfig, PagePortalId } from '../config'
import { authUrlLogin, authUrlLogout, authUrlSignup, profileContext, ProfileContextData } from '../lib'

import UniNavSnippet from './universal-nav-snippet'

// eslint-disable-next-line @typescript-eslint/no-explicit-any
declare let tcUniNav: any

const Header: FC = () => {

const { profile, initialized: profileReady }: ProfileContextData = useContext(profileContext)
const [ready, setReady]: [boolean, Dispatch<SetStateAction<boolean>>] = useState<boolean>(false)
const headerInit: MutableRefObject<boolean> = useRef(false)
const navElementId: string = 'main-nav-el'

useEffect(() => {

UniNavSnippet(EnvironmentConfig.UNIVERSAL_NAV.URL)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to move this into a separate useEffect with no dependencies. We don't want the script to run multiple times.

Better yet, you can call UniNavSnippet even before the Header declaration - there's no need to wait for react to run before we can initialize the script (basically we can let the script download and react do it's thing in parallel).


if (headerInit.current || !profileReady || !tcUniNav) {
return
}

headerInit.current = true

tcUniNav(
'tool',
navElementId,
{
onReady() {
setReady(true)
document.getElementById('root')?.classList.add('app-ready')
},
signIn() { window.location.href = authUrlLogin() },
signOut() { window.location.href = authUrlLogout },
signUp() { window.location.href = authUrlSignup() },
// TODO: make this dynamic based on the current URL
toolName: 'Topcoder Academy',
user: profileReady && profile ? {
handle: profile.handle,
initials: `${profile.firstName.charAt(0)}${profile.lastName.charAt(0)}`,
photoURL: profile.photoURL,
userId: profile.userId,
} : undefined,
},
)
}, [profileReady, profile])

return (
<>
<div id={navElementId} />
<div
id={PagePortalId}
className={classNames('full-width-relative', !ready && 'hidden')}
/>
</>
)
}

export default Header
33 changes: 0 additions & 33 deletions src-ts/header/logo/Logo.module.scss

This file was deleted.

33 changes: 0 additions & 33 deletions src-ts/header/logo/Logo.tsx

This file was deleted.

1 change: 0 additions & 1 deletion src-ts/header/logo/index.ts

This file was deleted.

15 changes: 0 additions & 15 deletions src-ts/header/tool-selectors/ToolSelectors.tsx

This file was deleted.

1 change: 0 additions & 1 deletion src-ts/header/tool-selectors/index.ts

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Loading