PROD-3232 Adds the uni nav snippet -> PROD-3115_uni-nav #421
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttle linting and config refactor. #time 2h
vas3a
reviewed
Nov 19, 2022
src-ts/header/Header.tsx
Outdated
|
|
||
| useEffect(() => { | ||
|
|
||
| UniNavSnippet(EnvironmentConfig.UNIVERSAL_NAV.URL) |
There was a problem hiding this comment.
Better to move this into a separate useEffect with no dependencies. We don't want the script to run multiple times.
Better yet, you can call UniNavSnippet even before the Header declaration - there's no need to wait for react to run before we can initialize the script (basically we can let the script download and react do it's thing in parallel).
…v outside the scope of the Header component. #time 15m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Uni Nav snippet and does some other linting and config fixes.
It also removes all the now obsolete header code.
A future PR will change the tool title dynamically in the header when the tool changes.