Skip to content

UN-129 - improve universal-nav ssr placeholder #6828

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Feb 17, 2023
Merged

UN-129 - improve universal-nav ssr placeholder #6828

merged 63 commits into from
Feb 17, 2023

Conversation

vas3a
Copy link
Collaborator

@vas3a vas3a commented Feb 16, 2023

https://topcoder.atlassian.net/browse/UN-129

Improves the universal-nav's placeholder: show the correct number of navigation bars based on current url & type of nav

image
image

jmgasper and others added 30 commits October 17, 2022 11:55
@jmgasper
Updates to allow for downloading marathon match submissions for all c…
042711c 
…ompetitors

#6668
@jmgasper
Fix up lint issue
37d5eed
@jmgasper
Ignore failing test for now - only fails on CI/CD
8c750b2
@jmgasper
These test are frustrating - works fine locally, not in CI/CD
560a27f
@jmgasper
UI updates and fixes how we use the token for downloading marathon ma…
ffd115c 
…tch submissions
@jmgasper
UI updates for modal display of marathon match submissions
a215959 
#6691
@jmgasper
Fix merge issue
6ef811b
@jmgasper
Width fix
c3f6572
@jmgasper
Width fix
6ef9813
@jmgasper
Make date and time one line on submission history popup
2aedb4b
@suppermancool
fix: navigation should not go below footer
a0c41a7 
fix: keep discuss white even after it was visited
@igoroshko
Merge pull request #6736 from topcoder-platform/timeline-wall-api-iss…
90a5b86 
…ues-20-25

Issue 20 + 25: navigation should not go below footer
@suppermancool
fix: navigation should not go below footer
c47731b
@igoroshko
Merge pull request #6740 from topcoder-platform/timeline-wall-api-iss…
2e5fcfd 
…ues-20

fix: navigation should not go below footer
@suppermancool
fix: set initial value of sidebar navigation to current year
b088319
@igoroshko
Merge pull request #6741 from topcoder-platform/timeline-wall-api-iss…
6b56ed9 
…ues-29

fix: set initial value of sidebar navigation to current year
@suppermancool
fix: update error message modal
827d2b6
@suppermancool
fix: navigation should not go below footer
d60c7bb
@igoroshko
Merge pull request #6742 from topcoder-platform/timeline-wall-api-32
3cbd42a 
fix: update error message modal
@igoroshko
Merge pull request #6743 from topcoder-platform/timeline-wall-api-20
00bb74b 
fix: navigation should not go below footer
@jmgasper
Test fixes for 2023 footer / header dates
6365625
@nursoltan-s
add plugins to markdown renderer
bcf552e
@jmgasper
Merge pull request #6765 from nursoltan-s/latex_support_1
7aa7215 
add plugins to markdown renderer
@jmgasper
Merge pull request #6771 from topcoder-platform/latex_support
f3271ed 
Latex support
@luizrrodrigues
ci: remove develop from Dev env
d13bbea
@luizrrodrigues
Merge pull request #6763 from topcoder-platform/feature-timeline-wall
11a5aa6 
Remaining timeline wall features and bug fixes
@jmgasper
2 Round Challenge sporadically showing as 1 round
ca171b8
@luizrrodrigues
Added Spring lib
9f6f7aa
@luizrrodrigues
ci: deploy sprig-lib to Dev env
97f3c9a
@luizrrodrigues
Merge pull request #6786 from topcoder-platform/sprig-lib
583c53d 
Sprig lib
jmgasper and others added 20 commits February 2, 2023 07:03
@jmgasper
Compress timeline view
d40e4aa 
#6807
@jmgasper
Fix failing test
6d9aab7
@jmgasper
Revert "Fix failing test"
6108300 
This reverts commit 6d9aab7.
@jmgasper
Ok, React is being dumb about these snapshots
4d359da
@jmgasper
Merge branch 'universal_nav' into marathon_match_submission_download
837e740
@jmgasper
Updates to submission download buttons
78961db
@jmgasper
Fix failing test
3ee73d2
@jmgasper
Updated wording on time remaining in phase
f444233 
#6815
@jmgasper
Simplify user handling in uninav
fbf0f2c
@jmgasper
Lint errors
c7d083b
@jmgasper
Lint fix
b031ad3
@jmgasper
Markdown rendering fixes
eb99d69
@jmgasper
Additional download submission UAT tweaks
b36957a
@jmgasper
Merge pull request #6823 from topcoder-platform/marathon_match_submis…
f0f9de3 
…sion_download

Marathon match submission download / Collapsible timeline / Markdown rendering updates
@jmgasper
Fix for grey background flashing behind “Download All” button
d5acd6a
@jmgasper
Merge pull request #6825 from topcoder-platform/marathon_match_submis…
b1a0ddf 
…sion_download

Fix for grey background flashing behind “Download All” button
@jmgasper
Only show download for MM challenge type, not tag
5061db9
@jmgasper
Lint errors
f359796
@jmgasper
Revert "Only show download for MM challenge type, not tag"
a7c3e22 
This reverts commit 5061db9.

# Conflicts:
#	src/shared/components/challenge-detail/Submissions/index.jsx
@vas3a
UN-129 - improve universal-nav ssr placeholder
9611beb
@vas3a vas3a requested a review from jmgasper February 16, 2023 12:58
@jmgasper
Copy link
Collaborator

@vas3a - Can you change this to point to the universal_nav branch please instead of develop?

@vas3a vas3a changed the base branch from develop to universal_nav February 17, 2023 22:32
@vas3a
Copy link
Collaborator Author

vas3a commented Feb 17, 2023

@jmgasper This has been started from develop. Do you want me to rebase the changes on universal_nav and open a new PR?

@jmgasper jmgasper merged commit 77343fa into universal_nav Feb 17, 2023
@jmgasper
Copy link
Collaborator

@vas3a - Saw the update, thanks! The problem with develop is that it's actually deployed to staging, which uses the production uninav. Not sure why, as that's different than literally every other app we deploy, but I've learned not to question that sort of thing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmgasper jmgasper Awaiting requested review from jmgasper

@sushilshinde sushilshinde Awaiting requested review from sushilshinde

@ajefts ajefts Awaiting requested review from ajefts

@luizrrodrigues luizrrodrigues Awaiting requested review from luizrrodrigues

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@vas3a @jmgasper @suppermancool @igoroshko @nursoltan-s @luizrrodrigues