Disabled Verification btn #1712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixing the tests |
|
tests are fixed! |
|
This is not the expected fix. The issue is that when you enter the new password, the validation popup prevents the user from clicking the change password button http://take.ms/V4e4W so the user has to click outside of the input to hide the popup and then click change password. |
|
fixing it |
|
@ThomasKranitsas are you talking about this issue #1438 ? |
|
My bad! I thought this was related to another ticket |
|
@ThomasKranitsas can you please review this PR? |
ThomasKranitsas
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled Verification button when email is empty