fix: parser error on empty markup string, causing WSOD #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Error is thrown if rootNode isnt in scope and markup is not a typeof string
|
@marcosvega91 I applied your fix, seems to work perfectly 😄 |
marcosvega91
approved these changes
Jun 17, 2020
|
Super 👍, thanks! |
smeijer
changed the title
|
@all-contributors please add @JacobMGEvans for code |
|
I've put up a pull request to add @JacobMGEvans! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Bugfix related to #161
The Guard was modified now the Error is thrown if rootNode isn't in scope and markup is not a
typeof"string"Why:
The parser was triggering true when all the HTML was removed from the codemirror by the user.
Checklist:
Screenshot before the fix applied on live site (in original bug report)
Screenshot locally running with fix applied and the HTML manually removed
Tests ran after the fix is applied.
