Application Crash On CodeMirror Clear

[JacobMGEvans]

Issue description

Steps to reproduce the issue

1. Select All HTML in First Code Mirror Block
2. Clear (backspace)
3. White Screen with console errors (screenshot)

What's the expected result?

Clearing the codemirror completely allows me to add in HTML afterward. Cleared codemirror doesn't crash the application.

What's the actual result?

Application crashes, production fatal crash white screen, reload required to restore.

Additional details / screenshot

[marcosvega91]

Hi @JacobMGEvans thanks for the report.
I think that this diff should be good to fix this issue. What do you think? Do you wanna work on it? 😄

diff --git a/src/parser.js b/src/parser.js
index e23d4ce..e4bcecd 100644
--- a/src/parser.js
+++ b/src/parser.js
@@ -243,7 +243,7 @@ function runUnsafe({ rootNode, query }) {
 }
 
 function parse({ rootNode, markup, query, cacheId, prevResult }) {
-  if (!markup && !rootNode) {
+  if (typeof markup !== 'string' && !rootNode) {
     throw new Error('either markup or rootNode should be provided');
   }

[JacobMGEvans]

yeah, I can take it up! Thanks for the diff too!!

[marcosvega91]

Thanks to you for your time 🥳