Skip to content

Remove Simulate from dependencies #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 25, 2018
Merged

Remove Simulate from dependencies #210

merged 6 commits into from
Oct 25, 2018

Conversation

vitalyso
Copy link
Contributor

What:
Removed react-tom/test-utils as a dependency

Why:
The biggest reason is #129 (see more details #206)

How:
By creating the createReactEventSimulator function that makes possible to simulate React events

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

@kentcdodds kentcdodds changed the base branch from pr/remove-simulate to master October 24, 2018 06:33
@kentcdodds kentcdodds changed the base branch from master to pr/remove-simulate October 24, 2018 06:33
kentcdodds
kentcdodds reviewed Oct 24, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, it looks like this PR is being made to the pr/remove-simulate branch. Could you rebase your changes onto master. May actually be easier to create a new branch based on master and add your changes over again and make a PR. Either way is fine with me :)

@vitalyso vitalyso changed the base branch from pr/remove-simulate to master October 24, 2018 07:02
@vitalyso
Copy link
Contributor Author

@kentcdodds I've made rebase, but I'm concerned if I have broken something 😅

@vitalyso vitalyso force-pushed the pr/remove-simulate branch 3 times, most recently from 1d2dc64 to 799d6ca Compare October 24, 2018 09:19
kentcdodds
kentcdodds reviewed Oct 24, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looking at this now I think there are things we can improve. What do you think?

@vitalyso
Copy link
Contributor Author

Sure, I will do 👍

@vitalyso vitalyso mentioned this pull request Oct 25, 2018
Closed
4 tasks
@vitalyso
Copy link
Contributor Author

OK, I got tests passing with using just native events 😄(thanks to @weyert's comment)
I'll commit it after some refactoring.

@weyert
Copy link
Contributor

weyert commented Oct 25, 2018

Awesome!

kentcdodds
kentcdodds approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fantastic! Thanks both of you for your research and work here 👏👏👏

@kentcdodds kentcdodds merged commit 6f898a9 into testing-library:master Oct 25, 2018
@vitalyso vitalyso deleted the pr/remove-simulate branch October 25, 2018 13:33
@vitalyso vitalyso restored the pr/remove-simulate branch October 25, 2018 13:34
@kentcdodds
Copy link
Member

I'm struggling to release this. There's something wrong with our automation. I may not get to it until after next week.

@weyert
Copy link
Contributor

weyert commented Oct 25, 2018 •
edited
Loading

The other ticket suggests it's a rights issue?

"The push permission to the Git repository is required.
semantic-release cannot push the version tag to the branch master on remote Git repository with URL http://[secure]@github.com/kentcdodds/react-testing-library.git."

@kentcdodds
Copy link
Member

🎉 This PR is included in version 5.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kentcdodds
Copy link
Member

Sweet! Got this working!

lucbpz pushed a commit to lucbpz/react-testing-library that referenced this pull request Jul 26, 2020
@allcontributors
docs: add jmcriffey as a contributor (testing-library#210)
26e1442 
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kentcdodds kentcdodds kentcdodds approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vitalyso @weyert @kentcdodds