Skip to content

Export setNativeValue #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vitalyso
Copy link

What:
Exported setNativeValue

Why:
It can be used by dependent libraries, e.g. in the react-testing-library

How:
Added setNativeValue to the export statement in the src/events.js file

Checklist:

  • Documentation N/A
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

@kentcdodds
Copy link
Member

Let's hold off on this one until we know that it's necessary. I'm thinking it wont be...

@vitalyso
Copy link
Author

OK, what about testing-library/react-testing-library#210 (comment) then?

@kentcdodds
Copy link
Member

I'm thinking that we can rework that implementation to not need setNativeValue :)

@kentcdodds
Copy link
Member

We worked out how to do what we needed without exposing this!

testing-library/react-testing-library#210

@kentcdodds kentcdodds closed this Oct 25, 2018
@vitalyso vitalyso deleted the pr/export-set-native-value branch October 26, 2018 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants