Replace getElementByText with getByText #150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
Jul 31, 2018
ematipico
approved these changes
Aug 1, 2018
antsmartian
approved these changes
Aug 4, 2018
There was a problem hiding this comment.
LGTM. Also we have done the same changes in dom-testing-library as well : testing-library/dom-testing-library@f5f369c
Should be good to merge.
cc @kentcdodds
|
Would you like to add yourself to the contributors table? |
|
🎉 This PR is included in version 4.1.7 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
julienw
pushed a commit
to julienw/react-testing-library
that referenced
this pull request
Dec 20, 2018
lucbpz
pushed a commit
to lucbpz/react-testing-library
that referenced
this pull request
Jul 26, 2020
…den-master Skywickenden master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to testing-library/dom-testing-library#82.
What: Use getByText instead of getElementByText in a code example, which seems like it was a typo.
Why: getElementByText is not exported by dom-testing-library as far as I'm aware, which could be confusing.
Checklist: