Skip to content

docs: add a video series to learning material #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2018
Merged

docs: add a video series to learning material #149

merged 1 commit into from
Jul 29, 2018

Conversation

divyanshu013
Copy link
Contributor

@divyanshu013 divyanshu013 commented Jul 29, 2018

What:
Adds a new video series that I created with my friend @metagrover using react-testing-library to the Learning Material section

Why:
This should help someone in case they are thinking of getting started with building a react library and testing with react-testing-library.

How:
Added in README.md

Checklist:

  • Documentation
  • Tests N/A
  • Ready to be merged
  • Added myself to contributors table

Hi Kent 👋

I worked on creating this series with my friend @metagrover. We're using react-testing-library for testing. The source code is at https://github.com/wtjs/tooltip

I noticed that I wasn't able to run the setup with Node 10 stable. Also when running validate I get some errors:

[build] src/index.js -> dist/index.js
[build] npm run build --silent exited with code 0
[test]  FAIL   library  src/__tests__/debug.js
[test]   ● Test suite failed to run
[test]
[test]     SecurityError: localStorage is not available for opaque origins
[test]
[test]       at Window.get localStorage [as localStorage] (node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
[test]           at Array.forEach (<anonymous>)

Although they shouldn't be related to this PR, thought would just let you know.

Thanks!

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! Thanks :)

@kentcdodds kentcdodds merged commit 37919b0 into testing-library:master Jul 29, 2018
@bishwenduk029
Copy link

@divyanshu013 , actually Jsdom was updated a few days back and they have introduced this new localstorage check, you can bind the jsdom version to previous one in your projects' package.json. Please ignore if you have already have a solution for the same. I also ran into similar issue few days back.

@kentcdodds
Copy link
Member

🎉 This PR is included in version 4.1.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

julienw pushed a commit to julienw/react-testing-library that referenced this pull request Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants