Skip to content

fix(allByLabelText): forEach on NodeList is not supported in edge #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 15, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 15, 2020

Copy of #463 which got lost when merging beta into master.

@eps1lon eps1lon added the bug Something isn't working label Mar 15, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 911124a:

Sandbox Source
happy-brook-979hw Configuration

@codecov
Copy link

codecov bot commented Mar 15, 2020

Codecov Report

Merging #487 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #487   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          22     22           
  Lines         423    423           
  Branches      101    101           
=====================================
  Hits          423    423
Impacted Files Coverage Δ
src/queries/label-text.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2885c9...911124a. Read the comment docs.

@kentcdodds kentcdodds merged commit 976675b into testing-library:master Mar 15, 2020
@kentcdodds
Copy link
Member

Still no idea why we lost three changes. But hopefully this was the last! Thank you.

@kentcdodds
Copy link
Member

🎉 This PR is included in version 7.0.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@eps1lon eps1lon deleted the fix/foreach branch March 15, 2020 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants