Skip to content

fix(allByLabelText): forEach on NodeList is not supported in edge #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Mar 4, 2020

What:

fixes crash in Edge when using getAllByLabelText

Why:

forEach is not implemented in NodeList in edge 15

How:

Convert NodeList to array before using forEach

Checklist:

  • [ ] Documentation added to the
    docs site
  • [ ] I've prepared a PR for types targeting
    DefinitelyTyped
  • Tests (will run codesandbox canary on Material-UI
  • Ready to be merged

@eps1lon eps1lon added the bug Something isn't working label Mar 4, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 4, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit da3f39c:

Sandbox Source
optimistic-paper-wyynf Configuration

@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #463 into beta will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              beta      #463   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines          419       419           
  Branches       100       100           
=========================================
  Hits           419       419           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bb57a9...da3f39c. Read the comment docs.

@eps1lon eps1lon merged commit ab6d90f into testing-library:beta Mar 4, 2020
@eps1lon eps1lon deleted the fix/foreach branch March 4, 2020 22:06
@eps1lon eps1lon restored the fix/foreach branch March 15, 2020 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant