Skip to content

tests: add output to a version parse error #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 5, 2024

Conversation

oleg-jukovec
Copy link
Collaborator

@oleg-jukovec oleg-jukovec commented Dec 5, 2024

Now it is difficult to determine a reason of a tarantool --version parsing error. The patch adds a command output to the error to make it easier.

The patchset includes other non-critical updates:

ci: replace macos-12 with macos-13

The macos-12 is no longer supported by GitHub.

tests: update a negative check of MP_ARROW decoding

The patch updates a check according to a latest Tarantool 3.3.0 release

Closes #415

@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/version-helper-output branch from c341fe0 to 8e76f56 Compare December 5, 2024 06:36
Now it is difficult to determine a reason of a `tarantool --version`
parsing error. The patch adds a command output to the error to make
it easier.
The macos-12 is no longer supported by GitHub.
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/version-helper-output branch from 8e76f56 to d21f2e8 Compare December 5, 2024 06:52
The patch updates a check according to a latest Tarantool 3.3.0
release.

Closes #415
@oleg-jukovec oleg-jukovec force-pushed the oleg-jukovec/version-helper-output branch from d21f2e8 to f270a60 Compare December 5, 2024 06:55
Copy link

@themilchenko themilchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch! Looks good to me.

@oleg-jukovec oleg-jukovec merged commit fbc69d4 into master Dec 5, 2024
26 checks passed
@oleg-jukovec oleg-jukovec deleted the oleg-jukovec/version-helper-output branch December 5, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support new error format in ‎arrow/tarantool_test.go / TestInsert_invalid
3 participants