-
-
Notifications
You must be signed in to change notification settings - Fork 3
Fix types of automatic and classic runtimes #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
wooorm
merged 5 commits into
syntax-tree:runtime-types
from
remcohaszing:fix-automatic-runtime-children-types
May 4, 2021
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
1aa3100
Make type definitions work for classic runtime
remcohaszing 3fabdc0
Specify automatic runtime uses children prop
remcohaszing d2f5897
Remve unused eslint-disable comments
remcohaszing 06ce846
Update test-d/classic.tsx
remcohaszing 87d2001
Describe diff between automatic and classic runtime
remcohaszing File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,48 +1,46 @@ | ||
import {XAttributes, XChild, XResult, x} from './index.js' | ||
import {XAttributes, XChild, XResult} from './index.js' | ||
|
||
/** | ||
* This unique symbol is declared to specify the key on which JSX children are passed, without conflicting | ||
* with the Attributes type. | ||
*/ | ||
declare const children: unique symbol | ||
|
||
export namespace JSX { | ||
/** | ||
* This defines the return value of JSX syntax. | ||
*/ | ||
type Element = XResult | ||
/** | ||
* This defines the return value of JSX syntax. | ||
*/ | ||
export type Element = XResult | ||
|
||
/** | ||
* This disallows the use of functional components. | ||
*/ | ||
type IntrinsicAttributes = never | ||
/** | ||
* This disallows the use of functional components. | ||
*/ | ||
export type IntrinsicAttributes = never | ||
|
||
/** | ||
* This defines the prop types for known elements. | ||
* | ||
* For `xastscript` this defines any string may be used in combination with `xast` `Attributes`. | ||
* | ||
* This **must** be an interface. | ||
*/ | ||
// eslint-disable-next-line @typescript-eslint/consistent-indexed-object-style | ||
interface IntrinsicElements { | ||
[name: string]: | ||
| XAttributes | ||
| { | ||
/** | ||
* The prop that matches `ElementChildrenAttribute` key defines the type of JSX children, defines the children type. | ||
*/ | ||
[children]?: XChild | ||
} | ||
} | ||
/** | ||
* This defines the prop types for known elements. | ||
* | ||
* For `xastscript` this defines any string may be used in combination with `xast` `Attributes`. | ||
* | ||
* This **must** be an interface. | ||
*/ | ||
// eslint-disable-next-line @typescript-eslint/consistent-indexed-object-style | ||
export interface IntrinsicElements { | ||
[name: string]: | ||
| XAttributes | ||
| { | ||
/** | ||
* The prop that matches `ElementChildrenAttribute` key defines the type of JSX children, defines the children type. | ||
*/ | ||
[children]?: XChild | ||
} | ||
} | ||
|
||
/** | ||
* The key of this interface defines as what prop children are passed. | ||
*/ | ||
export interface ElementChildrenAttribute { | ||
/** | ||
* The key of this interface defines as what prop children are passed. | ||
* Only the key matters, not the value. | ||
*/ | ||
interface ElementChildrenAttribute { | ||
/** | ||
* Only the key matters, not the value. | ||
*/ | ||
[children]?: never | ||
} | ||
[children]?: never | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.