Fix types of automatic and classic runtimes #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nesting properties in a `@typedef` type annotation will generate a namespace, which can be used to generate the required JSX namespace.
This specifies the children prop must be a valid xast child for the automatic runtime, but a valid attribute for the classic runtime.
ChristianMurphy
approved these changes
May 3, 2021
There was a problem hiding this comment.
Thanks @remcohaszing!
Looks good, seems that in the process it also fixed an ESLint warning, and the linter now wants the disable removed
/home/runner/work/xastscript/xastscript/test-d/classic.tsx: line 10, col 19, Error - '@typescript-eslint/no-unsafe-argument' rule is disabled but never reported. (eslint-comments/no-unused-disable)
ChristianMurphy
approved these changes
May 3, 2021
Co-authored-by: Titus <tituswormer@gmail.com>
ChristianMurphy
approved these changes
May 4, 2021
wooorm
approved these changes
May 4, 2021
wooorm
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
This specifies the children prop must be a valid xast child for the automatic runtime, but a valid attribute for the classic runtime.