Skip to content

types: ensure location attrs exists #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

types: ensure location attrs exists #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ function createLocation(ctx, node, location) {
let key

for (key in location.attrs) {
if (own.call(location.attrs, key)) {
if (location.attrs && own.call(location.attrs, key)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no good reason for this code inside the loop (other than TypeScript), it looks like a bug that a constant condition is checked on every iteration.

If TypeScript is indeed correct that location.attrs can be missing, then we already have an if-branch where that could be checked: L282. What do you think of using that?

props[find(ctx.schema, key).property] = position(location.attrs[key])
}
}
Expand Down