types: ensure location attrs exists #13
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👋 phase/new
wooorm
reviewed
Mar 4, 2022
| @@ -286,7 +286,7 @@ function createLocation(ctx, node, location) { | |||
| let key | |||
|
|
|||
| for (key in location.attrs) { | |||
| if (own.call(location.attrs, key)) { | |||
| if (location.attrs && own.call(location.attrs, key)) { | |||
There was a problem hiding this comment.
There is no good reason for this code inside the loop (other than TypeScript), it looks like a bug that a constant condition is checked on every iteration.
If TypeScript is indeed correct that location.attrs can be missing, then we already have an if-branch where that could be checked: L282. What do you think of using that?
|
Ping! |
1 similar comment
|
Ping! |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
TypeScript can't quite infer that
location.attris not undefined from the loop, this gives TS an extra hint.