Skip to content

[2.6] Removed dead code and various cleaning #13481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2015

Conversation

saro0h
Copy link
Contributor

@saro0h saro0h commented Jan 21, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

In complement of this one: #13488

@saro0h saro0h force-pushed the vacuum-cleaner-backintime branch 2 times, most recently from 89b545f to 1b2b5c1 Compare January 21, 2015 13:34
@stof
Copy link
Member

stof commented Jan 21, 2015

Shouldn't some of these even be done in 2.3 or 2.5 ?

@saro0h
Copy link
Contributor Author

saro0h commented Jan 21, 2015

No idea… I'll check once I've reduced the one in #13470 to not have redoundancy between 2.6 and 2.7.

@saro0h saro0h force-pushed the vacuum-cleaner-backintime branch 3 times, most recently from f9372ce to 9824448 Compare January 21, 2015 19:52
@fabpot
Copy link
Member

fabpot commented Jan 25, 2015

Thank you @saro0h.

@fabpot fabpot merged commit dbbe170 into symfony:2.6 Jan 25, 2015
fabpot added a commit that referenced this pull request Jan 25, 2015
This PR was merged into the 2.6 branch.

Discussion
----------

[2.6] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of this one: #13488

Commits
-------

dbbe170 Removed dead code and various cleaning
fabpot added a commit that referenced this pull request Jan 25, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of these: #13488 & #13481

Commits
-------

9272f86 Removed dead code and various cleaning
fabpot added a commit to symfony/form that referenced this pull request Jan 25, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of these: symfony/symfony#13488 & symfony/symfony#13481

Commits
-------

9272f86 Removed dead code and various cleaning
fabpot added a commit to symfony/validator that referenced this pull request Jan 25, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of these: symfony/symfony#13488 & symfony/symfony#13481

Commits
-------

9272f86 Removed dead code and various cleaning
fabpot added a commit to symfony/form that referenced this pull request Jan 25, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of these: symfony/symfony#13488 & symfony/symfony#13481

Commits
-------

9272f86 Removed dead code and various cleaning
@saro0h saro0h deleted the vacuum-cleaner-backintime branch January 26, 2015 19:44
fago pushed a commit to fago/Validator that referenced this pull request Apr 18, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of these: symfony/symfony#13488 & symfony/symfony#13481

Commits
-------

9272f86 Removed dead code and various cleaning
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants