Skip to content

[2.7] Removed dead code and various cleaning #13470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 25, 2015
Merged

Conversation

saro0h
Copy link
Contributor

@saro0h saro0h commented Jan 20, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

In complement of these: #13488 & #13481

@@ -18,7 +18,7 @@
*/
class DeprecationErrorHandler
{
public static function handle($errorNumber, $message, $file, $line, $context)
public static function handle($errorNumber, $message, $file, $line)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bc break, same below

@saro0h saro0h force-pushed the vacuum-cleaner branch 2 times, most recently from 848116b to 683ec07 Compare January 21, 2015 10:14
@saro0h saro0h force-pushed the vacuum-cleaner branch 2 times, most recently from 0ec2c99 to 8b8d27b Compare January 21, 2015 16:42
@fabpot
Copy link
Member

fabpot commented Jan 25, 2015

Thank you @saro0h.

@fabpot fabpot merged commit 9272f86 into symfony:2.7 Jan 25, 2015
fabpot added a commit that referenced this pull request Jan 25, 2015
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] Removed dead code and various cleaning

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ~
| License       | MIT
| Doc PR        | ~

In complement of these: #13488 & #13481

Commits
-------

9272f86 Removed dead code and various cleaning
@saro0h saro0h deleted the vacuum-cleaner branch January 26, 2015 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants