This repository was archived by the owner on Nov 27, 2020. It is now read-only.
Make the app/config/*.yml files validate #427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You cannot start a Plain Style Scalar with an Indicator (%). Play Style
Scalars which have a leading % should be changed to double-quote style
scalars.
fixes #426
|
This would need updates in the docs too? |
|
I would agree; however, wouldn't that be an issue and pull for a different repo (not symfony-standard)? |
|
Yes, but this PR won't be merged until the docs are done in a PR to https://github.com/symfony/symfony-docs |
|
Strange enough it appears this has already started to have been addressed and I would consider it now to be incosistent: http://symfony.com/doc/current/book/page_creation.html#application-configuration framework:
secret: "%secret%"
router: { resource: "%kernel.root_dir%/config/routing.yml" } |
You cannot start a Plain Style Scalar with an Indicator (%). Plain Style Scalars which have a leading % should be changed to double-quote style scalars. for #426
|
@isleshocky77 Can you submit a PR on the 2.1 branch instead? For the docs, I think we just need to create a ticket so that it is not lost. Thanks. |
This was referenced Oct 6, 2012
fabpot
added a commit
that referenced
this pull request
Oct 6, 2012
This PR was merged into the 2.1 branch. Commits ------- 8c03340 You cannot start a Plain Style Scalar with an Indicator (%). Plain Style Scalars which have a leading % should be changed to double-quote style scalars. 9afa2c1 Correcting YAML Markup in app/config to be valid YAML 1.2o Discussion ---------- Make the app/config/*.yml files validate You cannot start a Plain Style Scalar with an Indicator (%). Play Style Scalars which have a leading % should be changed to double-quote style scalars. fixes #426 see #427
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You cannot start a Plain Style Scalar with an Indicator (%). Play Style
Scalars which have a leading % should be changed to double-quote style
scalars.
fixes #426