Skip to content

Shouldn't be using invalid yaml in the code or docs for Plain Style Scalars starting with % #1770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Shouldn't be using invalid yaml in the code or docs for Plain Style Scalars starting with % #1770

wants to merge 1 commit into from

Conversation

isleshocky77
Copy link
Contributor

Updated the docs to make sure we don't have any instances of

key:    %value%

This is invalid yaml mark up.
See: symfony/symfony-standard#427

@isleshocky77
Update all docs to not recommend invalid YAML.
2b01a1f 
Updated the docs to make sure we don't have any instances of

```yaml
key:    %value%
```

This invalid yaml mark up.
See: symfony/symfony-standard#427
@weaverryan
Copy link
Member

Hi Stephen!

First, this is a really great PR! But, since this affects the 2.0 branch, the changes (and PR) need to be made against the 2.0 branch. I can usually patch into the 2.0 branch, but this has touched on things that are on 2.0 only as well as 2.1 and master.

Would it be possible to re-create this PR, based off of the 2.0 branch?

Thanks!

@isleshocky77
Copy link
Contributor Author

Yeah, not a problem. I'll try to get this out to you this weekend.
Do I need to create a pull request for the 2.0 branch, the 2.1 branch,
and the master branch?

Currently I have it against the master.

On 10/05/2012 05:21 PM, Ryan Weaver wrote:

Hi Stephen!

First, this is a really great PR! But, since this affects the 2.0
branch, the changes (and PR) need to be made against the 2.0 branch. I
can usually patch into the 2.0 branch, but this has touched on things
that are on 2.0 only as well as 2.1 and master.

Would it be possible to re-create this PR, based off of the 2.0 branch?

Thanks!

—
Reply to this email directly or view it on GitHub
#1770 (comment).

isleshocky77 added a commit to isleshocky77/symfony-docs that referenced this pull request Oct 6, 2012
@isleshocky77
Update all docs to not recommend invalid YAML.
2dae187 
Updated the docs to make sure we don't have any instances of

```yaml
key:    %value%
```

This invalid yaml mark up.
See: symfony#1770 symfony#1770
See: symfony/symfony-standard#427
@isleshocky77 isleshocky77 mentioned this pull request Oct 6, 2012
Merged
@weaverryan weaverryan closed this Oct 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@isleshocky77 @weaverryan