This repository was archived by the owner on Nov 14, 2019. It is now read-only.
Don't create README.md on cleanup #139
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xelaris thanks for fixing this issue and for improving the user experience with this change. |
javiereguiluz
added a commit
that referenced
this pull request
Apr 7, 2015
This PR was merged into the 1.0-dev branch. Discussion ---------- Don't create README.md on cleanup In case of an exception, e.g. when typing an invalid version number, the `cleanUp` method gets called. Since the `README.md` file was dumped there, the target directory wasn't empty on the next try, so it wasn't possible to re-run the command without manually removing the file. Commits ------- a4198d6 Don't create README.md on cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of an exception, e.g. when typing an invalid version number, the
cleanUpmethod gets called. Since theREADME.mdfile was dumped there, the target directory wasn't empty on the next try, so it wasn't possible to re-run the command without manually removing the file.