bug #139 Don't create README.md on cleanup (xelaris)

This PR was merged into the 1.0-dev branch.

Discussion
----------

Don't create README.md on cleanup

In case of an exception, e.g. when typing an invalid version number, the `cleanUp` method gets called. Since the `README.md` file was dumped there, the target directory wasn't empty on the next try, so it wasn't possible to re-run the command without manually removing the file.

Commits
-------

a4198d6 Don't create README.md on cleanup

Author: javiereguiluz

src/Symfony/Installer/NewCommand.php

@@ -58,6 +58,7 @@ protected function execute(InputInterface $input, OutputInterface $output)
                 ->download()
                 ->extract()
                 ->cleanUp()
+                ->dumpReadmeFile()
                 ->updateParameters()
                 ->updateComposerJson()
                 ->createGitIgnore()
@@ -202,9 +203,6 @@ protected function cleanUp()
 
             $filesToRemove = array_merge($licenseFile, $upgradeFiles, $changelogFiles);
             $this->fs->remove($filesToRemove);
-
-            $readmeContents = sprintf("%s\n%s\n\nA Symfony project created on %s.\n", $this->projectName, str_repeat('=', strlen($this->projectName)), date('F j, Y, g:i a'));
-            $this->fs->dumpFile($this->projectDir.'/README.md', $readmeContents);
         } catch (\Exception $e) {
             // don't throw an exception in case any of the Symfony-related files cannot
             // be removed, because this is just an enhancement, not something mandatory
@@ -262,6 +260,25 @@ protected function displayInstallationResult()
         return $this;
     }
 
+    /**
+     * Dump a basic README.md file.
+     *
+     * @return NewCommand
+     */
+    protected function dumpReadmeFile()
+    {
+        $readmeContents = sprintf("%s\n%s\n\nA Symfony project created on %s.\n", $this->projectName, str_repeat('=', strlen($this->projectName)), date('F j, Y, g:i a'));
+        try {
+            $this->fs->dumpFile($this->projectDir.'/README.md', $readmeContents);
+        } catch (\Exception $e) {
+            // don't throw an exception in case the file could not be created,
+            // because this is just an enhancement, not something mandatory
+            // for the project
+        }
+
+        return $this;
+    }
+
     /**
      * Updates the Symfony parameters.yml file to replace default configuration
      * values with better generated values.