Skip to content

[Twig] AppRuntime autoconfigurable in runtime example #9999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[Twig] AppRuntime autoconfigurable in runtime example #9999

wants to merge 1 commit into from

Conversation

slaci
Copy link

@slaci slaci commented Jul 3, 2018

In the twig runtime's doc there is a sentence below the last example:

If you're using the default services.yaml configuration, this will already work!

This is not true without RuntimeExtensionInterface interface, otherwise autoconfigure won't work. The interface is only available since twig 1.35.0 and 2.4.4 though.

This autoconfigure works since 3.4 I think, but docs before 4.1 contain manually adding the tag to the service, so I didn't change those.

@javiereguiluz
Copy link
Member

@slaci thanks a lot for fixing this error! Sadly, this morning I merged a different pull request that fixed this (#10025). Of course your pull request was created first, so yours should be merged instead.

We are usually very careful with this, so I apologize for my mistake. This was going to be your first Symfony Docs contribution, so I'm truly sorry. I hope you send other contributions in the future. Thank you!

@slaci
Copy link
Author

slaci commented Jul 6, 2018

No problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants