Add missing RuntimeExtensionInterface #10025
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the Twig runtime class does not implement RuntimeExtensionInterface, the autoconfigure feature of the container will not tag it with `twig.runtime`, and an exception will be thrown ("Unable to load the "App\Twig\AppRuntime" runtime.")
yceruto
reviewed
Jul 5, 2018
templating/twig_extension.rst
Outdated
| @@ -117,8 +117,10 @@ previous ``priceFilter()`` method:: | |||
|
|
|||
| // src/Twig/AppRuntime.php | |||
| namespace App\Twig; | |||
|
|
|||
| use use Twig\Extension\RuntimeExtensionInterface; | |||
|
Rémi, thanks for fixing this issue in the example code ... and congrats on your first contribution to Symfony Docs! We merged it in 3.4 and later we'll merge it in the other branches automatically. |
javiereguiluz
added a commit
that referenced
this pull request
Jul 6, 2018
…iluz) This PR was submitted for the 4.1 branch but it was merged into the 3.4 branch instead (closes #10025). Discussion ---------- Add missing RuntimeExtensionInterface If the Twig runtime class does not implement RuntimeExtensionInterface, the autoconfigure feature of the container will not tag it with `twig.runtime`, and an exception will be thrown ("Unable to load the "App\Twig\AppRuntime" runtime.") <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 4e9b044 Added the missing versionadded directive cb102c1 Remove duplicate `use` keyword 0e8d863 Add missing RuntimeExtensionInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the Twig runtime class does not implement RuntimeExtensionInterface, the autoconfigure feature of the container will not tag it with
twig.runtime, and an exception will be thrown ("Unable to load the "App\Twig\AppRuntime" runtime.")