Skip to content

json-login-ldap #9987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2018
Merged

json-login-ldap #9987

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions reference/configuration/security.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ LDAP functionality
------------------

There are several options for connecting against an LDAP server,
using the ``form_login_ldap`` and ``http_basic_ldap`` authentication
using the ``form_login_ldap``, ``http_basic_ldap`` and ``json_login_ldap`` authentication
providers or the ``ldap`` user provider.

For even more details, see :doc:`/security/ldap`.
Expand All @@ -191,8 +191,8 @@ Authentication
~~~~~~~~~~~~~~

You can authenticate to an LDAP server using the LDAP variants of the
``form_login`` and ``http_basic`` authentication providers. Simply use
``form_login_ldap`` and ``http_basic_ldap``, which will attempt to
``form_login``, ``http_basic`` and ``json_login`` authentication providers. Simply use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted and back ported in 3.4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this comment. The entire pull request should be done in 3.4 branch? Only part of the changes? If so, which ones? Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the change on this line, adding json_login, it is a Symfony 3 feature.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeahDude it's related to LDAP, so i think it's not related to SF3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ldap added its own very lately. See symfony/symfony#18952

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HeahDude
yes, but the LDAP variant of json_login does not exist on Symfony 3

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, and the change on this line has nothing to do with it :). There are two different changes in this PR, one must be back ported to previous version.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can authenticate to an LDAP server using the LDAP variants of the it has to do with it. On SF 3 there are no variant of json_login so json_login is not mention as a variant.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes you're right, sorry for the confusion.

``form_login_ldap``, ``http_basic_ldap`` and ``json_login_ldap``, which will attempt to
``bind`` against a LDAP server instead of using password comparison.

Both authentication providers have the same arguments as their normal
Expand Down Expand Up @@ -231,8 +231,8 @@ User provider

Users will still be fetched from the configured user provider. If you
wish to fetch your users from a LDAP server, you will need to use the
``ldap`` user provider, in addition to one of the two authentication
providers (``form_login_ldap`` or ``http_basic_ldap``).
``ldap`` user provider, in addition to one of the three authentication
providers (``form_login_ldap`` or ``http_basic_ldap`` or ``json-login-ldap``).

.. configuration-block::

Expand Down