json-login-ldap #9987
json-login-ldap #9987
Conversation
reference/configuration/security.rst
Outdated
| @@ -164,7 +164,7 @@ logout_on_user_change | |||
| **type**: ``boolean`` **default**: ``false`` | |||
|
|
|||
| .. versionadded:: 3.4 | |||
| The ``logout_on_user_change`` option was introduced in Symfony 3.4. | |||
| The ``logout_on_user_change`` option was introduced in Symfony 3.4. | |||
|
@nicolas-grekas done |
| @@ -191,8 +191,8 @@ Authentication | |||
| ~~~~~~~~~~~~~~ | |||
|
|
|||
| You can authenticate to an LDAP server using the LDAP variants of the | |||
| ``form_login`` and ``http_basic`` authentication providers. Simply use | |||
| ``form_login_ldap`` and ``http_basic_ldap``, which will attempt to | |||
| ``form_login``, ``http_basic`` and ``json_login`` authentication providers. Simply use | |||
There was a problem hiding this comment.
This should be reverted and back ported in 3.4
There was a problem hiding this comment.
I don't understand this comment. The entire pull request should be done in 3.4 branch? Only part of the changes? If so, which ones? Thanks!
There was a problem hiding this comment.
Only the change on this line, adding json_login, it is a Symfony 3 feature.
There was a problem hiding this comment.
@HeahDude it's related to LDAP, so i think it's not related to SF3
There was a problem hiding this comment.
Ldap added its own very lately. See symfony/symfony#18952
There was a problem hiding this comment.
@HeahDude
yes, but the LDAP variant of json_login does not exist on Symfony 3
There was a problem hiding this comment.
Yes, and the change on this line has nothing to do with it :). There are two different changes in this PR, one must be back ported to previous version.
There was a problem hiding this comment.
You can authenticate to an LDAP server using the LDAP variants of the it has to do with it. On SF 3 there are no variant of json_login so json_login is not mention as a variant.
There was a problem hiding this comment.
Yes you're right, sorry for the confusion.
HeahDude
added
Security
Waiting Code Merge
| @@ -191,8 +191,8 @@ Authentication | |||
| ~~~~~~~~~~~~~~ | |||
|
|
|||
| You can authenticate to an LDAP server using the LDAP variants of the | |||
| ``form_login`` and ``http_basic`` authentication providers. Simply use | |||
| ``form_login_ldap`` and ``http_basic_ldap``, which will attempt to | |||
| ``form_login``, ``http_basic`` and ``json_login`` authentication providers. Simply use | |||
There was a problem hiding this comment.
Yes you're right, sorry for the confusion.
javiereguiluz
removed
the
Waiting Code Merge
|
@ronfroy thank you for having contributed this feature and its docs! Congrats on your first Symfony Docs contribution! |
This PR was merged into the master branch. Discussion ---------- json-login-ldap symfony/symfony#27650 Commits ------- de28118 json-login-ldap
symfony/symfony#27650