Skip to content

Fix factory-service new syntax in the last example #9730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix factory-service new syntax in the last example #9730

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion service_container/factories.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ example takes the ``templating`` service as an argument:
# ...

AppBundle\Email\NewsletterManager:
factory: 'AppBundle\Email\NewsletterManagerFactory:createNewsletterManager'
factory: 'AppBundle\Email\NewsletterManagerFactory::createNewsletterManager'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks wrong to me. Using two colons means that method is treated as being static. But in here we do want to refer to a service with the id AppBundle\Email\NewsletterManagerFactory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, for sure, I did not pay attention to App\Email\NewsletterManagerFactory: ~, it just looks like the full name of the class, which is confusing. It is necessary to return back the use of only one colon.
Sorry for the confusion :(

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries :) But I am going to close here then.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but do not forget to return to use only one colon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there is anything to change, but a misunderstanding of what the Definition class does at that point. The thing is that your YAML config will already have been processed by the YamlFileLoader so that the $factory property in the Definition class will not be a string anyway.

arguments: ['@templating']

.. code-block:: xml
Expand Down