Fix factory-service new syntax in the last example #9730
Conversation
| @@ -188,7 +188,7 @@ example takes the ``templating`` service as an argument: | |||
| # ... | |||
|
|
|||
| AppBundle\Email\NewsletterManager: | |||
| factory: 'AppBundle\Email\NewsletterManagerFactory:createNewsletterManager' | |||
| factory: 'AppBundle\Email\NewsletterManagerFactory::createNewsletterManager' | |||
There was a problem hiding this comment.
This change looks wrong to me. Using two colons means that method is treated as being static. But in here we do want to refer to a service with the id AppBundle\Email\NewsletterManagerFactory.
There was a problem hiding this comment.
Yes, for sure, I did not pay attention to App\Email\NewsletterManagerFactory: ~, it just looks like the full name of the class, which is confusing. It is necessary to return back the use of only one colon.
Sorry for the confusion :(
There was a problem hiding this comment.
No worries :) But I am going to close here then.
There was a problem hiding this comment.
Sure, but do not forget to return to use only one colon.
There was a problem hiding this comment.
I don't think there is anything to change, but a misunderstanding of what the Definition class does at that point. The thing is that your YAML config will already have been processed by the YamlFileLoader so that the $factory property in the Definition class will not be a string anyway.
It is in fact the continuation of #9701, I'm sorry, I overlooked, and did not fix the new syntax in the last example :(
And an important note! Changes in this PR and #9701 should concern the versions of Symfony, starting with
3.4, not 2.x (eg2.7). So I created a separate PR #9729, which returns the "old" syntax to version 2.x, because only one colon is needed because the identifier (app.newsletter_manager_factory) is used, not the full class name (App\Email\NewsletterManagerStaticFactory, then in this case exactly two colons are required!