Documented how to create lazy-loaded Twig extensions #9204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
approved these changes
Feb 22, 2018
| Creating Lazy-Loaded Twig Extensions | ||
| ------------------------------------ | ||
|
|
||
| .. versionadded:: 1.26 |
There was a problem hiding this comment.
Don't we refer to Symfony versions here? Having a Twig version seems weird to me.
There was a problem hiding this comment.
Yes, it's not very common, but we add those version numbers for Twig and other apps different than Symfony in some places of the docs.
templating/twig_extension.rst
Outdated
|
|
||
| class AppRuntime | ||
| { | ||
| // for complex Twig extensions you may need to define a constructor |
There was a problem hiding this comment.
I would even say that if you don't have dependencies, you should never create a runtime.
There was a problem hiding this comment.
I agree. I've reworded some things. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #7169.