Use stricter syntax when testing #9046
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e.g. `$mailCollector->getMessageCount()` returns an int so its better to use $this->assertSame will also meaning faster testing and better testing within the example given.
javiereguiluz
approved these changes
Jan 13, 2018
|
Thanks Matthew. |
javiereguiluz
added a commit
that referenced
this pull request
Jan 13, 2018
This PR was submitted for the 4.0 branch but it was merged into the 2.7 branch instead (closes #9046). Discussion ---------- Use stricter syntax when testing e.g. ```php $mailCollector->getMessageCount(); ``` returns an int so its better to use ```php $this->assertSame($expected, $actual); ```` will also meaning faster testing and better testing within the given example. Commits ------- 3d8ee63 Use stricter syntax when testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g.
returns an int so its better to use
will also meaning faster testing and better testing within the given example.